#1 2018-01-31 22:18:12

van der Decken
Member
Registered: 2018-01-30
Posts: 27

Statistics on filtered results

I noticed that the statistics seem to always report on the entire collection, rather than the currently filtered results. Is this by design? I dug into the code a bit and a one line change to the stats subroutine was all I needed to have the stats work on the filtered data only. I like it better that way but there may be good reasons why it was implemented the way it is that I'm not aware of. In any case, I've attached a patch file showing what I did if anyone's interested.


Attachments:
Attachment Icon stats-on-filtered-results.patch, Size: 764 bytes, Downloads: 48

Offline

 

#2 2018-02-07 12:23:19

kerenoc
Member
Registered: 2016-03-19
Posts: 217
Website

Re: Statistics on filtered results

Thanks for fixing and contributing back (committed to GitLab).

Online

 

#3 2018-02-10 19:08:56

kerenoc
Member
Registered: 2016-03-19
Posts: 217
Website

Re: Statistics on filtered results

I started testing more seriously the statistic function. In some occasion, selecting the output with bars will raise an exception. Did you also experience that?

Online

 

#4 2018-02-11 17:05:22

van der Decken
Member
Registered: 2018-01-30
Posts: 27

Re: Statistics on filtered results

No, I haven't seen that one yet. Although I have seen the dialog window become unresponsive once in a blue moon so perhaps that's what's happening. It hasn't happened often enough for me to be able to figure out how to duplicate it yet.

Offline

 



Should you have a problem using GCstar, you can open a bug report or request some support on GCstar forums.