#1 2007-03-31 23:32:15

robby
New member
Registered: 2007-03-31
Posts: 8

Tellico export includes dot in image format

Hi Tian,

The Tellico exporter includes the dot in the image format. Tellico copes with that ok, but it's probably a bit more correct to not include it. Just a minor thing.

Code:

Index: lib/gcstar/GCExport/GCExportTellico.pm
===================================================================
RCS file: /cvs/gcstar/gcstar/lib/gcstar/GCExport/GCExportTellico.pm,v
retrieving revision 1.19
diff -u -3 -p -r1.19 GCExportTellico.pm
--- lib/gcstar/GCExport/GCExportTellico.pm      11 Feb 2007 18:33:47 -00001.19
+++ lib/gcstar/GCExport/GCExportTellico.pm      31 Mar 2007 23:30:15 -0000
@@ -155,7 +155,7 @@ use GCExport::GCExportBase;
     {
         my ($self, $file) = @_;
         my $image = GCUtils::getDisplayedImage($file, $self->{options}->{defaultImage}, $self->{original});
-        (my $suffix = $image) =~ s/.*?(\.[^.]*)$/$1/;
+        (my $suffix = $image) =~ s/.*?\.([^.]*)$/$1/;
         $suffix = '.jpeg' if $suffix eq '.jpg';
         my $capsSuffix = uc $suffix;
         open PIC, "<$image" or return (undef,undef,undef);

Marco Constanti on the Alexandria project noticed it.
http://rubyforge.org/pipermail/alexandr … 01243.html

Offline

 

#2 2007-04-01 12:53:20

Tian
Administrator
From: France
Registered: 2006-12-08
Posts: 1647
Website

Re: Tellico export includes dot in image format

Hi,

Thank you very much for this patch. I added it to the CVS version and also to the update repository for version 1.1.1.

Offline

 



Should you have a problem using GCstar, you can open a bug report or request some support on GCstar forums.