GCstar forums - [Patch] Upper limit on range comparison not restored

I noticed tonight that when I edited an advanced search conting a range comparison on a number field, the upper limit was being restored correctly. It was being set to the lower limit. I dug into the code a bit and discovered that in GCBasicWidgets.pm, the setValue function in the GCRange package was using $values[0] for both {from} and {to}, rather than $values[1] for {to}. I think that's an oops. I changed the last line to '$self->{to}->setValue($values[1]);' and that seems to have fixed the problem. A patch file is attached.

    sub setValue
    {
        my ($self, $value) = @_;
        my @values = split m/;/, $value;
        $self->{from}->setValue($values[0]);
        $self->{to}->setValue($values[0]);
    }

---

Attachments:
range-comparison-fix.patch, Size: 419 bytes, Downloads: 600